chore: add reusable submodule update workflow and slack notifications#5
Merged
chore: add reusable submodule update workflow and slack notifications#5
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a reusable
update-submodulesworkflow that both registry repos can call, and adds Slack notifications + script injection fixes to the existingupdate-lockfileworkflow.Changes
.github/workflows/update-submodules.yaml— reusable workflow with inputs forcommit_message,pr_title,pr_branch, andhas_https_submodules(boolean to control HTTPS→PAT URL rewriting).github/workflows/update-lockfile.yaml— added optionalSLACK_WEBHOOK_URLsecret and notification step, using env vars instead of direct${{ }}interpolation in shell (fixes script injection anti-pattern)Type of Change
Testing
Checklist
Notes
Supersedes PR #4 (
bw/slack-notification). Merge this first, then the registry caller PRs.Link to Devin session: https://app.devin.ai/sessions/7768353d8ede429eb108f2c272e88747
Requested by: @BradenBug